[os-infrastructure] Commit Messages

Grant Croker grant.croker at ingres.com
Fri May 2 01:19:11 PDT 2008


Alex,

I don't believe SVN maintains any notion of bugs / changes. That would 
have to be something maintained externally. Providing a command line 
client would not be too difficult. A web service that spits out the 
changes for a bug could be made based on data collected for the 
pre-commit hook. Or I guess we could look to see what ever problem 
tracker can also do the same.


g


On 02/05/08 09:41, Alex Hanshaw wrote:
> Hi Andrew
>
> Which change are associated with a bug is something that we'd like to 
> be able to do on the command line.
> "P describe -b" equivalent. Switching between a build konsole and a 
> web browser to do this is better than
> not having the functionality but not particularly efficient for SE day 
> to day usage.
>
> Alex
>
> On Thu, 2008-05-01 at 17:24 -0400, Andrew Ross wrote:
>> Alex, Grant
>>
>> I'd like to confirm the use case here as it seems it should be straight
>> forward with the right tool. Does this sound correct?
>>
>>   Given a customer issue, what are the bugs associated with it?
>>   Given a customer issue, what are the code changes associated with it?
>>   Given a bug, what are the code changes associated with it?
>>
>> This is ideally available via. a web browser, and also a CLI tool that's
>> quick and easy to use?
>>
>> Confirmed?
>>
>>  Andrew
>>
>> -----Original Message-----
>> From: opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com>
>> [mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com>] On Behalf Of
>> Grant Croker
>> Sent: April 30, 2008 7:06 PM
>> To: Alex Hanshaw
>> Cc: OpenSourceInfrastructure
>> Subject: Re: [os-infrastructure] Commit Messages
>>
>> Agreed - it needs to be added to the list of issues so that a workable
>> solution can be provided.
>>
>> On 30/04/08 18:56, Alex Hanshaw wrote:
>> > Pass. If you are suggesting a full svn log of all changes looking for 
>> > a commit message containing the bug we're interested in then that 
>> > would get to be a slow process really quickly (Unless the details are 
>> > available locally).
>> >
>> > Alex
>> >
>> > On Wed, 2008-04-30 at 18:36 +0200, Grant Croker wrote:
>> >> I do not think so. Unlike piccolo, SVN et al., are not tied to bug 
>> >> tracking systems. One way it can be done is with svn log and awk or 
>> >> other utilities.
>> >>
>> >> svn log can dump its info in XML which also can be parsed using a
>> script.
>> >>
>> >> Would that be ok?
>> >>
>> >> g
>> >>
>> >> On 30/04/08 18:08, Alex Hanshaw wrote:
>> >> > Will the hooks provide the reverse so that we can list change 
>> >> > details for a given bug?
>> >> >
>> >> > svn log can be used to list change details, but I see no equivalent
>>
>> >> > to "p describe -b"
>> >> >
>> >> > Alex
>> >> >
>> >> > On Wed, 2008-04-30 at 18:03 +0200, Grant Croker wrote:
>> >> >> You need login (or perhaps even root) access to code.ingres.com to
>>
>> >> >> do that. One thing the SVN server does now is to check the bug 
>> >> >> number against the list of tickets in trac (or whatever ticket 
>> >> >> system we end up using). By extension it could insert entries in 
>> >> >> to the relevant ticket saying : "Bug # fixed with change rev Y".
>> >> >>
>> >> >> We need to work out what impact adding the pre-revprop-change hook
>>
>> >> >> implies and should it re-validate the new message as the 
>> >> >> pre-commit hook does.
>> >> >>
>> >> >> g
>> >> >>
>> >> >> On 30/04/08 17:51, Bodo Bergmann wrote:
>> >> >> > Why not just use:
>> >> >> >
>> >> >> > svnadmin setlog --bypass-hooks REPOS_PATH -r REVISION FILE
>> >> >> >
>> >> >> > From the description of "svnadmin setlog" in the svn-book:
>> >> >> >
>> >> >> > Set the log-message on revision REVISION to the contents of
>> FILE.
>> >> >> > This is similar to using svn propset --revprop to set the 
>> >> >> > svn:log property on a revision, except that you can also use the
>>
>> >> >> > option --bypass-hooks to avoid running any pre- or post-commit 
>> >> >> > hooks, which is useful if the modification of revision 
>> >> >> > properties has not been enabled in the pre-revprop-change hook.
>> >> >> >
>> >> >> >
>> >> >> > Bodo.
>> >> >> >
>> >> >> > -----Original Message-----
>> >> >> > From: opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com> 
>> >> >> > <mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com>> 
>> >> >> > <mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com> 
>> >> >> > <mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com>>>
>> >> >> > [mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com> 
>> >> >> > <mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com>> 
>> >> >> > <mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com> 
>> >> >> > <mailto:opensource-infrastructure-bounces at lists.ingres.com <mailto:opensource-infrastructure-bounces at lists.ingres.com>>>] On
>>
>> >> >> > Behalf Of Grant Croker
>> >> >> > Sent: Wednesday, April 30, 2008 5:45 PM
>> >> >> > To: Alex Hanshaw
>> >> >> > Cc: OpenSourceInfrastructure
>> >> >> > Subject: Re: [os-infrastructure] Commit Messages
>> >> >> >
>> >> >> > It possible but it is not set-up at the moment - this is from a 
>> >> >> > discussion I had with Chuck Thibert I had yesterday:
>> >> >> >   
>> >> >> >> There's another hook that svn is looking for:
>> >> >> >>
>> >> >> >> [cthibert at localhost ingres-newmain]$ svn propedit svn:log 
>> >> >> >> --username
>> >> >> >> thich01 --revprop -r32 --editor-cmd vi
>> >> >> >> svn: DAV request failed; it's possible that the repository's 
>> >> >> >> pre-revprop-change hook either failed or is non-existent
>> >> >> >> svn: At least one property change failed; repository is 
>> >> >> >> unchanged [cthibert at localhost ingres-newmain]$
>> >> >> >>
>> >> >> >> The pre-revprop-change hook.  I'm not sure which checks are 
>> >> >> >> desired/required to allow changes to a prop after the fact.
>> >> >> >>
>> >> >> >> I think it would be nice to allow some of these changes, since 
>> >> >> >> it
>> >> >> >>     
>> >> >> > would
>> >> >> >   
>> >> >> >> mirror p's ability to change release notes too.  We may be able
>>
>> >> >> >> to use the svn logs much like we currently use p's logs for 
>> >> >> >> release notes
>> >> >> >>     
>> >> >> > etc.
>> >> >> >
>> >> >> >
>> >> >> >
>> >> >> > On 30/04/08 17:40, Alex Hanshaw wrote:
>> >> >> >   
>> >> >> >> I've not managed to work out how a commit message can be 
>> >> >> >> updated after
>> >> >> >>     
>> >> >> >
>> >> >> >   
>> >> >> >> a changes has been committed.
>> >> >> >> For example, I submit a change that bumps the build revision to
>>
>> >> >> >> 4 with
>> >> >> >>     
>> >> >> >
>> >> >> >   
>> >> >> >> a comment stating:
>> >> >> >> "Fix Bug 123444"
>> >> >> >> If I spot that the bug number have a typo, can I update the 
>> >> >> >> commit message for revision 4?
>> >> >> >>
>> >> >> >> Given that out release notes may well have to be be embedded 
>> >> >> >> inside the commit message this is something we are going to 
>> >> >> >> need to be able to do.
>> >> >> >>
>> >> >> >> Alex
>> >> >> >>
>> >> >> >> Alex Hanshaw
>> >> >> >> Manager, Sustaining Engineering *Ingres Europe Limited* 
>> >> >> >> _alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com> <mailto:_alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com>> 
>> >> >> >> <mailto:_alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com> 
>> >> >> >> <mailto:_alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com>>> 
>> >> >> >> <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com> 
>> >> >> >> <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com>> 
>> >> >> >> <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com> 
>> >> >> >> <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com>>>>_
>> >> >> >>
>> >> >> >> *PHONE* +44 01753 559515
>> >> >> >> *MOBILE*+44 07793 757929
>> >> >> >>
>> >> >> >> *_www.ingres.com <http://www.ingres.com/>_*
>> >> >> >>
>> >> >> >> This transmission is confidential and intended solely for the 
>> >> >> >> use of the recipient named above. It may contain confidential, 
>> >> >> >> proprietary, or legally privileged information. If you are not 
>> >> >> >> the intended recipient, you are hereby notified that any 
>> >> >> >> unauthorized review, use, disclosure or distribution is 
>> >> >> >> strictly prohibited. If you have received this transmission in 
>> >> >> >> error, please contact the sender by reply e-mail and delete the
>>
>> >> >> >> original transmission and all copies from your system.
>> >> >> >>
>> >> >> >>
>> >> >> >>     
>> >> >> > ----------------------------------------------------------------
>> >> >> > --------
>> >> >> >   
>> >> >> >> _______________________________________________
>> >> >> >> opensource-infrastructure mailing list 
>> >> >> >> opensource-infrastructure at lists.ingres.com <mailto:opensource-infrastructure at lists.ingres.com> 
>> >> >> >> <mailto:opensource-infrastructure at lists.ingres.com <mailto:opensource-infrastructure at lists.ingres.com>> 
>> >> >> >> <mailto:opensource-infrastructure at lists.ingres.com <mailto:opensource-infrastructure at lists.ingres.com> 
>> >> >> >> <mailto:opensource-infrastructure at lists.ingres.com <mailto:opensource-infrastructure at lists.ingres.com>>>
>> >> >> >> http://lists.ingres.com/mailman/listinfo/opensource-infrastruct
>> >> >> >> ure
>> >> >> >>   
>> >> >> >>     
>> >> >> >
>> >> >> >
>> >> >> >   
>> >> >>
>> >> >>
>> >> >> --
>> >> >> Grant Croker - Ingres PHP, Ruby and Python maintainer Gods don't 
>> >> >> like people not doing much work. People who aren't busy all the
>> time might start to think.
>> >> >>     -- Terry Pratchett, Small Gods
>> >> >>
>> >> >>     
>> >> > Alex Hanshaw
>> >> > Manager, Sustaining Engineering
>> >> > *Ingres Europe Limited*
>> >> > _alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com> <mailto:_alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com>> 
>> >> > <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com> <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com>>>_
>> >> >
>> >> > *PHONE* +44 01753 559515
>> >> > *MOBILE*+44 07793 757929
>> >> >
>> >> > *_www.ingres.com <http://www.ingres.com/>_*
>> >> >
>> >> > This transmission is confidential and intended solely for the use 
>> >> > of the recipient named above. It may contain confidential, 
>> >> > proprietary, or legally privileged information. If you are not the 
>> >> > intended recipient, you are hereby notified that any unauthorized 
>> >> > review, use, disclosure or distribution is strictly prohibited. If 
>> >> > you have received this transmission in error, please contact the 
>> >> > sender by reply e-mail and delete the original transmission and all
>>
>> >> > copies from your system.
>> >> >
>> >>
>> >>
>> >>     
>> > Alex Hanshaw
>> > Manager, Sustaining Engineering
>> > *Ingres Europe Limited*
>> > _alex.hanshaw at ingres.com <mailto:_alex.hanshaw at ingres.com> <mailto:alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com>>_
>> >
>> > *PHONE* +44 01753 559515
>> > *MOBILE*+44 07793 757929
>> >
>> > *_www.ingres.com <http://www.ingres.com/>_*
>> >
>> > This transmission is confidential and intended solely for the use of 
>> > the recipient named above. It may contain confidential, proprietary, 
>> > or legally privileged information. If you are not the intended 
>> > recipient, you are hereby notified that any unauthorized review, use, 
>> > disclosure or distribution is strictly prohibited. If you have 
>> > received this transmission in error, please contact the sender by 
>> > reply e-mail and delete the original transmission and all copies from 
>> > your system.
>> >
>>
>>
>> --
>> Grant Croker - Ingres PHP, Ruby and Python maintainer The trouble with
>> having an open mind, of course, is that people will insist on coming
>> along and trying to put things in it.
>>     -- Terry Pratchett
>>
>> _______________________________________________
>> opensource-infrastructure mailing list
>> opensource-infrastructure at lists.ingres.com <mailto:opensource-infrastructure at lists.ingres.com>
>> http://lists.ingres.com/mailman/listinfo/opensource-infrastructure
>>     
> Alex Hanshaw
> Manager, Sustaining Engineering
> *Ingres Europe Limited*
> _alex.hanshaw at ingres.com <mailto:alex.hanshaw at ingres.com>_
>
> *PHONE* +44 01753 559515
> *MOBILE*+44 07793 757929
>
> *_www.ingres.com <http://www.ingres.com/>_*
>
> This transmission is confidential and intended solely for the use of 
> the recipient named above. It may contain confidential, proprietary, 
> or legally privileged information. If you are not the intended 
> recipient, you are hereby notified that any unauthorized review, use, 
> disclosure or distribution is strictly prohibited. If you have 
> received this transmission in error, please contact the sender by 
> reply e-mail and delete the original transmission and all copies from 
> your system.
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> opensource-infrastructure mailing list
> opensource-infrastructure at lists.ingres.com
> http://lists.ingres.com/mailman/listinfo/opensource-infrastructure
>   


-- 
Grant Croker - Ingres PHP, Ruby and Python maintainer
Here the man in blue crimplene accosted us once more but we patiently
explained to him that he could **** off.



More information about the opensource-infrastructure mailing list